Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): dashboard workflow override #7253

Merged
merged 4 commits into from
Dec 10, 2024
Merged

fix(api): dashboard workflow override #7253

merged 4 commits into from
Dec 10, 2024

Conversation

djabarovgeorge
Copy link
Contributor

@djabarovgeorge djabarovgeorge commented Dec 9, 2024 •
edited
Loading

What changed? Why was the change needed?

The bug is the following:

  1. Enter the new dashboard.
  2. Create new workflow and call it new-workflow
  3. A new dashboard first workflow will be created with origin novu-cloud.
  4. Go to framework create workflow with workflowId new-workflow
  5. Sync Bridge.
  6. This update the workflow we created in step 2. meaning we will have dashboard first workflow with framework workflow data.

image

Fixing: NV-4898

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

@netlify Netlify
Copy link

netlify bot commented Dec 9, 2024 •
edited
Loading

✅ Deploy Preview for dashboard-v2-novu-staging ready!

Name Link
🔨 Latest commit 30a9dc0
🔍 Latest deploy log https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/67587352b1d45100080e7503
😎 Deploy Preview https://deploy-preview-7253.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 9, 2024 •
edited
Loading

✅ Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit 30a9dc0
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/67587352ef1de60008e9b380
😎 Deploy Preview https://deploy-preview-7253.dashboard.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@djabarovgeorge djabarovgeorge merged commit b8e300e into next Dec 10, 2024
29 of 30 checks passed
@djabarovgeorge djabarovgeorge deleted the fix-dashboard-workflow-override branch December 10, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SokratisVidros SokratisVidros SokratisVidros approved these changes

Assignees
No one assigned
Labels
@novu/api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djabarovgeorge @SokratisVidros